Sign in Go Pro

Android Clean Architecture

Tying together the browse projects and bookmarked projects activity

This lesson is for PRO members.

Upgrade today to get access to all the PRO lessons.

Unlock this lesson
Autoplay

Up next

Previous

About

Now that we have both of the Browse projects and Browse Bookmarked projects activities created, we need a way to navigate between the two. In this lesson, we're going to create the navigation logic to help our user move between the two screens.

Instructor

Links

Comments

Hi, I received two errors regarding the modules: UiModule.kt and DataModule.kt

error: @Binds methods must have only one parameter whose type is assignable to the return type public abstract error.NonExistentClass bindDataRepository(@org.jetbrains.annotations.NotNull()

error: @Binds methods must have only one parameter whose type is assignable to the return type public abstract error.NonExistentClass bindPostExecutionThread(@org.jetbrains.annotations.NotNull()
^
I'm not sure how to fix because I followed the videos as accordingly but I get those compilation errors.

This means that the class you're trying to pass to the bind method is not really implementing the class you're trying to return
e.g UiThread has to implement PostExecutionThread to do this
@Binds
abstract fun bindPostExecutionThread(uiThread: UiThread): PostExecutionThread
Hope this helps

if you've gotten this far in the course you'll find that there are quite a few missing pieces . I got it working after a bit of troubleshooting; The things I remember having to add that Joe has not shown in a video so far:

  1. You need to edit the Manifest file and add ""
  2. You need to set the adapter in both activities (AKA recyclerprojectsbookmarked.adapter = adapter)

If you're running into problems your best bet is to download Joe's working branch (Mobile_UI) and compare you're code to his.

Oh and Joe I think there's an error in your code as the back/up button doesn't work with just finish(). I changed it to NavUtils.navigateUpFromSameTask(this) to get it working.

By some reason I'm getting an error - cache.mapper.CachedProjectMapper cannot be provided without an @Inject constructor or from an @Provides-annotated method.

Where to put @Provides-annotated method ?

Hi Dmitry ..You need to inject ProjectsResponseModelMapper's default constructor. It should look something like this:

class ProjectsResponseModelMapper @Inject constructor(): ModelMapper {
}

We can just set android:parentActivityName=".browse.BrowseActivity" in the Manifest and back button will work without calling finish().

I added this code to the Bookmarked Activity:


override fun onOptionsItemSelected(item: MenuItem): Boolean {
return when (item.itemId) {
R.id.home -> {
NavUtils.navigateUpFromSameTask(this)
true
}
else -> {
super.onOptionsItemSelected(item)
}
}
}

I spend more time fixing bugs than watching videos. Lol.

Joe, my app keeps loading forever!!
The only thing that appears is the ProgressBar.
After 3 weeks of course all day studying, 74 lessons of all 80 of this course, this is very frustrating!!!
Debugging I can see that the app goes to "handleDataState" method of class "BrowseActivity", and then the apps goes to "ResourceState.LOADING -> {" and stays there forever!!

private fun handleDataState(resource: Resource<List<ProjectView>>) {
when (resource.status) {
ResourceState.SUCCESS -> {
setupScreenForSuccess(resource.data?.map {
mapper.mapToView(it)
})
}
ResourceState.LOADING -> {
progress.visibility = View.VISIBLE
recycler_projects.visibility = View.GONE
}
}
}

Joe, this course is complex, I am trying very hard to understand it.
Sincerely, I don't understand all the logic you applied along this course.

To understand everything, I have some goals: finish all 80 lessons; execute this app successfully; and finally, study this code in the minimum details.
Since I didn't finished all 80 lessons and couldn't run the app, I can't study this code in the minimum details.

That's why I ask you to please, try to test my code, and see why it isn't executing:
https://github.com/graffiti75/GithubTrending

Joe, I got with Donn Felker the source code from your app. Downloaded it, executed it, and the same thing happened:
the app keeps loading forever, and the only thing that appears is the ProgressBar.

Debugging your source code, I can see that the app goes to "handleDataState" method of class "BrowseActivity", and then the apps goes to "ResourceState.LOADING -> {" and stays there forever.

Hey Rodrigo, the code in the github repository should be working fine - I've just pulled a fresh copy down myself to check. Have you tried it on both wifi and mobile data connections? I'll double check through your repo to see if that one works for me and/or if there are any things that might be causing you an issue there

Hello Joe.
Yes, I have tried in both situations.

  • I'll double check through your repo to see if that one works for me and/or if there are any things that might be causing you an issue there

Thanks!

Hello Joe.
Any updates?

Hey Rodrigo,

I found this issue - will open up an issue on your repo 🙂

Joe, I am more than lost here:

  • First, a guy called Jean Pokou answered into my Github, and not you.
  • Then, he posted a code that wasn't my original code because there was a different line from that code to mine.
  • Then, this new code doesn't compile.
  • Then he gave me a hint about how to fix the code that wasn't my original code.

I appreciate all your help, but I must be sincere: I am lost here, needing some help to move on into this course.
Along 74 lessons I copied every code you passed in your videos. When there was some error, I checked with your Github.
Now my code does not run. And also your code from Github does not run.

I stopped the course in the last 5 days because of this.
So what should I do here? I need this code to run to move on into this course.

I already paid 2 months of Caster.io subscription. I am stucked in the moment...

Hi Rodrigo,

I've just made a couple of tweaks to your code and opened a PR, let's chat on there!

Hello Joe.
I saw your PR.
Since Jean Pokou fixed the issues before you, I left his changes on my code.
Now the app works and I can move on into the course.
If I have any other doubts, I will e-mail you.
Thanks for your help.

HI Joe
The Code you have posted is loading forever....
I have solved it by getting helped from Rodrigo Cericatto repository.
Please make changes in your code, so other students avoid this trouble :)

>

Lessons in Android Clean Architecture

1. Introduction to Clean Architecture
03:40
Joe Birch
GDE
2. Android and Clean Architecture
03:51
Joe Birch
GDE
3. Setting up a Multi-Module project
02:24
Joe Birch
GDE
4. Setting up the Domain layer module
02:24
Joe Birch
GDE
5. Creating the abstraction for our RxJava Observation Thread
02:02
Joe Birch
GDE
6. Setting up the Business Data for the Domain Layer
01:47
Joe Birch
GDE
7. Setting up the data access interface for the Domain Layer
01:49
Joe Birch
GDE
8. Setting up the Domain Layer Interactor classes
Pro
03:28
Joe Birch
GDE
9. Implementing the Get Projects use case
Pro
01:49
Joe Birch
GDE
10. Implementing the get Bookmarked Projects use case
Pro
01:33
Joe Birch
GDE
11. Implementing the Bookmark Project use case
Pro
01:57
Joe Birch
GDE
12. Implementing the UnBookmark Project use case (Domain layer 8)
Pro
02:03
Joe Birch
GDE
13. Testing the Get Projects use case
Pro
02:41
Joe Birch
GDE
14. Testing the Get Bookmarked Projects use case
Pro
02:04
Joe Birch
GDE
15. Testing the Bookmark Project use case
Pro
02:10
Joe Birch
GDE
16. Testing the UnBookmark Project use case
Pro
02:06
Joe Birch
GDE
17. Setting up the data module
Pro
02:17
Joe Birch
GDE
18. Creating the data models for the data layer
Pro
02:48
Joe Birch
GDE
19. Creating the external source interfaces for our data layer
Pro
02:24
Joe Birch
GDE
20. Creating the data layer store interface
Pro
01:19
Joe Birch
GDE
21. Creating the data layer cache data store
Pro
01:21
Joe Birch
GDE
22. Creating the data layer remote data store
Pro
01:39
Joe Birch
GDE
23. Creating the data store factory class
Pro
01:24
Joe Birch
GDE
24. Creating the central access point for the data layer
Pro
03:00
Joe Birch
GDE
25. Setting up the tests for the Data Layer
Pro
00:46
Joe Birch
GDE
26. Testing the data store factory class
Pro
01:39
Joe Birch
GDE
27. Testing the project entity mapper
Pro
01:18
Joe Birch
GDE
28. Testing the projects data repository
Pro
06:02
Joe Birch
GDE
29. Testing the projects cache data store
Pro
06:30
Joe Birch
GDE
30. Testing the projects remote data store
Pro
02:17
Joe Birch
GDE
31. Setting up the remote module
Pro
02:21
Joe Birch
GDE
32. Creating the data models for the remote layer
Pro
02:06
Joe Birch
GDE
33. Creating the Retrofit Service for the remote data source
Pro
01:58
Joe Birch
GDE
34. Creating the Retrofit Service Factory for the remote service interface
Pro
02:52
Joe Birch
GDE
35. Creating the data model mapper for the Remote Layer
Pro
01:59
Joe Birch
GDE
36. Creating the Remote Source implementation
Pro
01:55
Joe Birch
GDE
37. Setting up the Remote layer for testing
Pro
02:13
Joe Birch
GDE
38. Testing the remote model mapper class
Pro
01:39
Joe Birch
GDE
39. Testing the remote source implementation
Pro
05:09
Joe Birch
GDE
40. Setting up the Cache module
Pro
02:45
Joe Birch
GDE
41. Setting up the Cache layer data models
Pro
02:02
Joe Birch
GDE
42. Creating the database for the cache layer
Pro
01:34
Joe Birch
GDE
43. Creating the cached project Data Access Object
Pro
02:42
Joe Birch
GDE
44. Creating the Configuration Data Access Object
Pro
02:07
Joe Birch
GDE
45. Creating the cache model mapper
Pro
02:06
Joe Birch
GDE
46. Creating the Projects Cache data source Implementation
Pro
03:57
Joe Birch
GDE
47. Setting up the tests for our cache layer
Pro
01:17
Joe Birch
GDE
48. Testing the cached project model mapper
Pro
01:44
Joe Birch
GDE
49. Testing the Cached project DAO
Pro
04:33
Joe Birch
GDE
50. Testing the Configuration DAO
Pro
02:05
Joe Birch
GDE
51. Testing the projects cache implementation
Pro
05:48
Joe Birch
GDE
52. Setting up the presentation module
Pro
02:05
Joe Birch
GDE
53. Creating the data models for the presentation layer
Pro
01:13
Joe Birch
GDE
54. Creating the data model mapper for the presentation layer
Pro
01:26
Joe Birch
GDE
55. Creating the presentation state model
Pro
01:39
Joe Birch
GDE
56. Creating the browse projects view model
Pro
04:25
Joe Birch
GDE
57. Creating the bookmarked projects view model
Pro
03:05
Joe Birch
GDE
58. Setting up the presentation module tests
Pro
02:09
Joe Birch
GDE
59. Testing the view model mapper
Pro
01:17
Joe Birch
GDE
60. Testing our Browse Projects View Model implementation
Pro
04:36
Joe Birch
GDE
61. Testing our Browse Bookmarked Projects View Model implementation
Pro
04:34
Joe Birch
GDE
62. Setting up the UI module
Pro
02:22
Joe Birch
GDE
63. Creating the Post Execution Thread Implementation
Pro
01:26
Joe Birch
GDE
64. Setting up the application class
Pro
00:50
Joe Birch
GDE
65. Setting up the Dependency Injection for the UI module
Pro
02:46
Joe Birch
GDE
66. Creating the UI modules Project representation
Pro
00:50
Joe Birch
GDE
67. Creating the the Project model mapper for the UI module
Pro
01:24
Joe Birch
GDE
68. Setting up the Browse Projects Activity
Pro
01:08
Joe Birch
GDE
69. Configuring the DI for the project
Pro
04:37
Joe Birch
GDE
70. Creating the Project item view
Pro
01:51
Joe Birch
GDE
71. Creating the Browse Projects Adapter
Pro
03:27
Joe Birch
GDE
72. Creating the browse bookmarked projects adapter
Pro
03:54
Joe Birch
GDE
73. Creating the browse bookmarked projects activity
Pro
03:18
Joe Birch
GDE
74. Tying together the browse projects and bookmarked projects activity
Pro
02:30
Joe Birch
GDE
75. Setting up Unit Tests for the UI module
Pro
00:54
Joe Birch
GDE
76. Test the project model mapper
Pro
01:10
Joe Birch
GDE
77. Configuring the Dependency Injection for our User Interface tests
Pro
06:10
Joe Birch
GDE
78. Writing Espresso tests for the Browse Projects Activity
Pro
03:15
Joe Birch
GDE
79. Writing Espresso tests for the Bookmarked Projects Activity
Pro
02:34
Joe Birch
GDE
80. Simplifying the work we have done
Pro
05:14
Joe Birch
GDE